From a2f7af65e7ed423acdf2d656e3e90b3da4ac5c56 Mon Sep 17 00:00:00 2001
From: Price Hiller <price@orion-technologies.io>
Date: Tue, 17 Jan 2023 14:35:03 -0600
Subject: [PATCH] refactor(zsh): replace dotnet-suggest with in-built dotnet
 completion

---
 .../config/completions/completions/_dotnet    | 19 ++++++++++
 .../completions/completions/_dotnet_suggest   | 38 -------------------
 2 files changed, 19 insertions(+), 38 deletions(-)
 create mode 100644 dots/.config/zsh/config/completions/completions/_dotnet
 delete mode 100644 dots/.config/zsh/config/completions/completions/_dotnet_suggest

diff --git a/dots/.config/zsh/config/completions/completions/_dotnet b/dots/.config/zsh/config/completions/completions/_dotnet
new file mode 100644
index 00000000..8905b98f
--- /dev/null
+++ b/dots/.config/zsh/config/completions/completions/_dotnet
@@ -0,0 +1,19 @@
+#compdef dotnet
+# zsh parameter completion for the dotnet CLI
+
+_dotnet_zsh_complete()
+{
+  local completions=("$(dotnet complete "$words")")
+
+  # If the completion list is empty, just continue with filename selection
+  if [ -z "$completions" ]
+  then
+    _arguments '*::arguments: _normal'
+    return
+  fi
+
+  # This is not a variable assignment, don't remove spaces!
+  _values = "${(ps:\n:)completions}"
+}
+
+compdef _dotnet_zsh_complete dotnet
diff --git a/dots/.config/zsh/config/completions/completions/_dotnet_suggest b/dots/.config/zsh/config/completions/completions/_dotnet_suggest
deleted file mode 100644
index c86e3018..00000000
--- a/dots/.config/zsh/config/completions/completions/_dotnet_suggest
+++ /dev/null
@@ -1,38 +0,0 @@
-#compdef dotnet
-_dotnet_zsh_complete()
-{
-    # debug lines, uncomment to get state variables passed to this function
-    # echo "\n\n\nstate:\t'$state'"
-    # echo "line:\t'$line'"
-    # echo "words:\t$words"
-
-    # Get full path to script because dotnet-suggest needs it
-    # NOTE: this requires a command registered with dotnet-suggest be
-    # on the PATH
-    full_path=`which ${words[1]}` # zsh arrays are 1-indexed
-    # Get the full line
-    # $words array when quoted like this gets expanded out into the full line
-    full_line="$words"
-
-    # Get the completion results, will be newline-delimited
-    completions=$(dotnet suggest get --executable "$full_path" -- "$full_line")
-    # explode the completions by linefeed instead of by spaces into the descriptions for the
-    # _values helper function.
-
-    exploded=(${(f)completions})
-    # for later - once we have descriptions from dotnet suggest, we can stitch them
-    # together like so:
-    # described=()
-    # for i in {1..$#exploded}; do
-    #     argument="${exploded[$i]}"
-    #     description="hello description $i"
-    #     entry=($argument"["$description"]")
-    #     described+=("$entry")
-    # done
-    _values 'suggestions' $exploded
-}
-
-# apply this function to each command the dotnet-suggest knows about
-compdef _dotnet_zsh_complete $(dotnet-suggest list)
-
-export DOTNET_SUGGEST_SCRIPT_VERSION="1.0.0"